Skip to content

DATAJDBC-182 - Support modifying query on the query method #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATAJDBC-182 - Support modifying query on the query method #48

wants to merge 1 commit into from

Conversation

kazuki43zoo
Copy link
Contributor

I've fixed the DATAJDBC-182.

schauder pushed a commit that referenced this pull request Mar 9, 2018
@kazuki43zoo @schauder
DATAJDBC-182 - Support modifying annotated queries.
73fe1ca 
Added @modify for marking queries that perform DML or DDL.
Modifying queries with return type boolean or Boolean return wether the number of updated rows is greater 0.
This shouldn't be used for DML statements since it will always return false.

Original pull request: ##48.
@schauder
Copy link
Contributor

schauder commented Mar 9, 2018

That's merged.

Thanks for these high quality PRs.

@schauder schauder closed this Mar 9, 2018
@kazuki43zoo kazuki43zoo deleted the DATAJDBC-182 branch March 9, 2018 15:03
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
mp911de added a commit that referenced this pull request Feb 21, 2022
@mp911de
#48 - Atomically close connections.
836c5b4 
We now make sure to close connections only once by tracking the cleanup state. Flux.usingWhen/Mono.usingWhen do not ensure atomic cleanup in situations where the subscription completes and then the subscription is terminated.

This behavior has lead to closing a connection multiple times.

Related ticket: reactor/reactor-core#1486
mp911de added a commit that referenced this pull request Feb 21, 2022
@mp911de
#48 - Polishing.
3a1085e 
Formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazuki43zoo @schauder